Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency between cleaning and prep_files #9

Open
Phlogi opened this issue Dec 2, 2018 · 1 comment
Open

inconsistency between cleaning and prep_files #9

Phlogi opened this issue Dec 2, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@Phlogi
Copy link

Phlogi commented Dec 2, 2018

The clean scripts seems to write the following files in /res:

  • dilogues.p
  • your_sents.p
  • other_sents.p

While prep_files expects to read the following:

  • other_sents.p
  • your_embeddings.p
  • dilogues.p
  • your_sents.p
  • key_embeddings.p

This obviously fails.

@Spandan-Madan
Copy link
Owner

I'm sure it's just basic file renaming errors. When I initially wrote the code I was using a set of variable names with names of people. I changed it to be more generic before releasing the code.

Thanks for pointing this out, can you take a look at debugging this and creating a pull request if you have some time available?

Thanks a lot!

@Spandan-Madan Spandan-Madan added the help wanted Extra attention is needed label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants