Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-work the communicator timer #415

Open
pklampros opened this issue Apr 4, 2021 · 0 comments
Open

Re-work the communicator timer #415

pklampros opened this issue Apr 4, 2021 · 0 comments

Comments

@pklampros
Copy link
Collaborator

As raised in PR #414, the application hacks time_t, a type that usually stores Unix Epoch time i.e. in seconds to actually store milliseconds. The hack was probably applied to easily provide faster updates of UI elements (progress bars) under one second, but should now be changed to a modern implementation such as std::chrono.

It might be worth completely removing the qtimer function altogether if a better implementation exists for such interval testing, instead of having to keep track of a time_t variable that is completely external to the function and to the communicator that is typically affected by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant