New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setPixelColor with scanLine() or bits() #391

Open

pklampros opened this issue Nov 8, 2020 · 0 comments

Labels

enhancement GUI VGA

Collaborator

pklampros commented Nov 8, 2020

From the qt docs for setPixelColor:

Warning: This function is expensive due to the call of the internal detach() function called within; if performance is a concern, we recommend the use of scanLine() or bits() to access pixel data directly.

As found when filling pointmap pixels:

depthmapX/depthmapX/views/glview/glpointmap.cpp

Line 67 in b943241

data.setPixelColor(x, y, qRgb(colour.redb(),colour.greenb(),colour.blueb()));

pklampros added enhancement VGA GUI labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment