Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow versions which provide build info to be versionchecked #839

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

sluetze
Copy link
Contributor

@sluetze sluetze commented Nov 21, 2024

Some Distributions provide buildinfo as extension to the semver

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>

this might result in version strings like Kubernetes Version: v1.29.8+f10c92d

currently, the version_check fails with "Unrecognized version format:"

This small change allows Kubernetes Distributions which provide the buildinfo to be versionchecked.

@sluetze sluetze changed the title allow versions which provide commit info allow versions which provide build info to be versionchecked Nov 21, 2024
sluetze and others added 2 commits November 26, 2024 11:47
Co-authored-by: Matthias Büchse <[email protected]>
Signed-off-by: sluetze <[email protected]>
@mbuechse mbuechse merged commit bfd8c3a into SovereignCloudStack:main Nov 26, 2024
3 checks passed
@mbuechse
Copy link
Contributor

Thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants