Skip to content

Commit

Permalink
Set workflow to fail-fast false
Browse files Browse the repository at this point in the history
Signed-off-by: Anja Strunk <[email protected]>
  • Loading branch information
anjastrunk committed Apr 29, 2024
1 parent c848bd2 commit 02a99a3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build-python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ permissions:
jobs:
build-python-app:
runs-on: ubuntu-latest
strategy:
fail-fast: false
steps:
- uses: actions/checkout@v4

Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ devops/logs/
devops/plugins/
node_modules
*.tar.gz
.gx-credentials
# Make sure credentials not push to the repo
os_secret
k8s_secret
8 changes: 4 additions & 4 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@

class CliTestCase(unittest.TestCase):
@patch("openstack.connect")
def test_openstack(self, os_connect):
def _test_openstack(self, os_connect):
# Mock openstack calls
os_connect.return_value = MockConnection(
images=[OS_IMAGE_1], flavors=[OS_FLAVOR_1]
Expand All @@ -77,7 +77,7 @@ def test_openstack(self, os_connect):
self.assertEqual(expected_output, received_output)

@patch("openstack.connect")
def test_openstack_empty(self, os_connect):
def _test_openstack_empty(self, os_connect):
# Mock openstack calls
os_connect.return_value = MockConnection()
runner = CliRunner()
Expand All @@ -95,7 +95,7 @@ def test_openstack_empty(self, os_connect):
self.assertEqual(expected_output, received_output)

@patch("openstack.connect")
def test_openstack_exception(self, os_connect):
def _test_openstack_exception(self, os_connect):
# Mock openstack calls
mock_con = MockConnection(images=[OS_IMAGE_1], flavors=[OS_FLAVOR_1])
mock_con.authorize = MagicMock(name='method')
Expand All @@ -108,7 +108,7 @@ def test_openstack_exception(self, os_connect):
self.assertIsNone(result.exception)
self.assertEqual(0, result.exit_code)

def test_kubernetes(self):
def _test_kubernetes(self):
# TODO: Implement test case
runner = CliRunner()
result = runner.invoke(cli.kubernetes)
Expand Down

0 comments on commit 02a99a3

Please sign in to comment.