Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] UI구현 #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Feat] UI구현 #1

wants to merge 8 commits into from

Conversation

mcrkgus
Copy link

@mcrkgus mcrkgus commented May 17, 2024

🔥Pull requests

👷 작업한 내용

  • 계산기 UI를 구현했어용

🚨 참고 사항

  • 연산하는 부분은 아직 미완성입니다!
  • 감이 잘 안 잡혀서 아티클 참고했습니다

📸 스크린샷

기능 스크린샷
GIF Simulator Screen Recording - iPhone 15 - 2024-05-17 at 16 48 31

참고한 자료

@mcrkgus mcrkgus requested a review from sozohoy May 17, 2024 08:03
Copy link
Member

@sozohoy sozohoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 가현아 고생했어!!! 코드 잘썼네~~ 잘했음!
  • 디자인 너무 귀엽다 근데 ㅋ

Comment on lines +24 to +32
case subtract = "\u{2212}"
case add = "\u{002B}"
case divide = "\u{00F7}"
case multiply = "\u{00D7}"
case equal = "="
case clear = "AC"
case decimal = "."
case percent = "%"
case negative = "\u{002B}/-"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 오!! 이부분 유니코드로 한 이유가 어떤 이유야??


import SwiftUI

enum CalculatorButton: String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • enum 활용한거 너무 좋다!

var body: some View {
VStack {
Spacer()
ForEach(buttons, id: \.self) { button in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 오 코드 너무 깔끔하게 잘썼다! 잘했어 !!!
  • 다음주에는 이 코드를 외부로 빼보고, body에서는 아무나 읽어도 뷰계층이 예상되게 구현해보면 더 좋은 코드가 될 것 같아 !!!! :) 이미 충분히 잘했네!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants