Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Android 14 Support added #75

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

hazmi-e205
Copy link
Contributor

@hazmi-e205 hazmi-e205 commented Feb 22, 2024

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并,Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过,并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

  • Ported InputManagerGlobalEventInjector to support input event for Android 14
  • Fixed crash SonicKeyboard on Android 14 because behavior changes of registerReceiver method
  • Fixed crash SonicManagerServiceV2 on Android 14 because behavior changes of startForeground method
  • Updated targetSdk and compileSdk to 34
  • Updated AGP to 8.2.2 and Gradle 8.6
  • Removed duplicate permissions

- Ported InputManagerGlobalEventInjector to support input event for Android 14
- Fixed crash SonicKeyboard on Android 14 because behavior changes of registerReceiver method
- Fixed crash SonicManagerServiceV2 on Android 14 because behavior changes of startForeground method
- Updated targetSdk and compileSdk to 34
- Updated AGP to 8.2.2 and Gradle 8.6
- Removed duplicate permissions
@hazmi-e205 hazmi-e205 changed the title Android 14 Support added feat: Android 14 Support added Feb 22, 2024
@prlabeler prlabeler bot added the feature label Feb 22, 2024
@ZhouYixun ZhouYixun requested review from ZhouYixun and wzasd February 22, 2024 07:44
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ap

@ZhouYixun
Copy link
Member

@hazmi-e205
Copy link
Contributor Author

https://github.com/SonicCloudOrg/sonic-android-apk/actions/runs/8001005334/job/21851547381?pr=75

Checking failed. @hazmi-e205

Require OpenJDK 17 to build using latest Gradle
where I can fix the CI?

@ZhouYixun
Copy link
Member

https://github.com/SonicCloudOrg/sonic-android-apk/actions/runs/8001005334/job/21851547381?pr=75
Checking failed. @hazmi-e205

Require OpenJDK 17 to build using latest Gradle where I can fix the CI?

https://github.com/SonicCloudOrg/sonic-android-apk/blob/main/.github/workflows/android.yml

Remember you should make sure apk can work with low Android version like Android 5-10 (if possible )

@hazmi-e205
Copy link
Contributor Author

https://github.com/SonicCloudOrg/sonic-android-apk/actions/runs/8001005334/job/21851547381?pr=75
Checking failed. @hazmi-e205

Require OpenJDK 17 to build using latest Gradle where I can fix the CI?

https://github.com/SonicCloudOrg/sonic-android-apk/blob/main/.github/workflows/android.yml

Remember you should make sure apk can work with low Android version like Android 5-10 (if possible )

Thanks for remaining me, will check it in my Android 7 device

@ZhouYixun
Copy link
Member

thanks!

@hazmi-e205
Copy link
Contributor Author

Tested in Android 7 and 14 with my latest commit, and both works

@ZhouYixun ZhouYixun merged commit c67453a into SonicCloudOrg:main Feb 23, 2024
@ZhouYixun
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants