SLI-1630 Download project list on background thread #1183
Conversation
eray-felek-sonarsource
force-pushed
the
feature/ef/SLI-1630-download-project-list-background
branch
2 times, most recently
from
b8c45df to
2c61425
Compare
src/main/java/org/sonarlint/intellij/tasks/ServerDownloadProjectTask.java
Outdated
Show resolved
Hide resolved
| } | ||
| return computeOnPooledThread("Download Projects", () -> { | ||
| try { | ||
| return waitForFuture(indicator, getService(BackendService.class) |
There was a problem hiding this comment.
It would be better to put the computeOnPooledThread just around the waitForFuture, inside the try/catch
There was a problem hiding this comment.
Actually this is not that better, ideally the catch should be outside, as it is catching any exception and it returns the error message to the dialog in the Wizard (so that the user can understand). But currently, the computeOnPooledThread is catching any exception as well and just returns null. I think it would be best if we add a new computeOnPooledThreadWithoutCatching, something like that, that would use a custom waitForTask that would throw the exception and not just catch it, so it can go back to the original call.
Probably a similar issue in other xxxTask where we used computeOnPooledThread
src/main/java/org/sonarlint/intellij/tasks/ServerDownloadProjectTask.java
Outdated
Show resolved
Hide resolved
eray-felek-sonarsource
force-pushed
the
feature/ef/SLI-1630-download-project-list-background
branch
2 times, most recently
from
7ff0bde to
7d80271
Compare
eray-felek-sonarsource
force-pushed
the
feature/ef/SLI-1630-download-project-list-background
branch
from
7d80271 to
2ee3f87
Compare
|
eray-felek-sonarsource
deleted the
feature/ef/SLI-1630-download-project-list-background
branch
SLI-1630