Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S5693: Resolve false positive for multer storage engine init #4886

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix S5693: Resolve false positive for multer storage engine init #4886

merged 1 commit into from
Nov 4, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Oct 28, 2024

Copied from #4851

@vdiez vdiez mentioned this pull request Oct 28, 2024
Closed
@vdiez vdiez changed the title Resolve false postive in S5693 for multer storage engine init Fix S5693: Resolve false positive in for multer storage engine init Oct 28, 2024
@vdiez vdiez changed the title Fix S5693: Resolve false positive in for multer storage engine init Fix S5693: Resolve false positive for multer storage engine init Oct 28, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

zglicz
zglicz approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmacro

@vdiez vdiez merged commit 1393aec into master Nov 4, 2024
17 of 18 checks passed
@vdiez vdiez deleted the fix-S5693 branch November 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zglicz zglicz zglicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdiez @zglicz