New improve test coverage #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
force-pushed
the
NEW_improve_test_coverage
branch
from
18b9baf
to
2cceb08
Compare
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
dukenuken09
had a problem deploying
to
cypress
GitHub Actions
Failure
vokimon
reviewed
Sep 25, 2024
cypress/fixtures/contract.json
Outdated
| "invalidCups": "ES9803463008824117ZQ", | ||
| "validCups": "ES0029874572863299XP", | ||
| "invalidCups": "ES0029874572863299XP", | ||
| "validCups": "ES0022458494204838TJES", |
There was a problem hiding this comment.
Este CUPS no es valido. Los dos ultimos digitos han de ser un numero y una letra, no dos letras. Normalmente un numero bajo 0, 1 o 2, y las legras F o P. Lo mas comun 0F. Seguramente si lo usamos para algo, en la validación remota, fallara.
vokimon
reviewed
Sep 25, 2024
src/App.jsx
Outdated
| @@ -159,7 +159,7 @@ const App = (props) => { | |||
|
|
|||
| <Route | |||
| path="/:language/contract-20/" | |||
| element={<Contract is30ContractEnabled={false} {...props} />} | |||
| element={<Contract {...{...props,is30ContractEnabled:false}} />} | |||
There was a problem hiding this comment.
Why? It is way harder to understand. Maybe because props overrided is30ContractEnabled? What about just changing the order?
dukenuken09
force-pushed
the
NEW_improve_test_coverage
branch
from
eceb45a
to
386ab37
Compare
dukenuken09
force-pushed
the
NEW_improve_test_coverage
branch
from
51b5096
to
0f54198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve test coverage of webforms-ui
Changes
is30ContractEnabledflagChecklist
Justify any unchecked point:
_paqto_mtmto run on local (for App.jsx, Contract.jsx and Member.jsx files). It will be discussed in a meeting with the whole team to determine to do address it.