-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mech/vehicle/omnivehicle turret fixes & improvements #316
Commits on Dec 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d7f6c6a - Browse repository at this point
Copy the full SHA d7f6c6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3a90ea - Browse repository at this point
Copy the full SHA a3a90eaView commit details -
Revamp mech turrets to fix edge cases and allow equipment, align turr…
…et/rear-mounting code
Configuration menu - View commit details
-
Copy full SHA for 04b2627 - Browse repository at this point
Copy the full SHA 04b2627View commit details -
Configuration menu - View commit details
-
Copy full SHA for d380751 - Browse repository at this point
Copy the full SHA d380751View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95d424f - Browse repository at this point
Copy the full SHA 95d424fView commit details -
Align rear-mounting menu logic with others wrt menu visibility and co…
…de, remove some redundant menu code
Configuration menu - View commit details
-
Copy full SHA for 7c1d4cf - Browse repository at this point
Copy the full SHA 7c1d4cfView commit details -
Fix regression from 04b2627 where items weren't actually added to mec…
…h turret for cost & weight purposes
Configuration menu - View commit details
-
Copy full SHA for 87f1cc2 - Browse repository at this point
Copy the full SHA 87f1cc2View commit details -
Fix regression from 2415ab5 and related omnivehicle that broke turret…
…s on non-omnivehicles on wide CV GUI Specifically, omnivehicle code didn't properly unset turret max tonnage when disabled, and the wide CV GUI specifically resets them to 0 even for non-omnivehicles. Also remove max tonnage stuff from sponson turrets since they're unrelated to omnivehicles. Note: non-wide CV omnivehicle code remains incomplete.
Configuration menu - View commit details
-
Copy full SHA for 0fbb9c0 - Browse repository at this point
Copy the full SHA 0fbb9c0View commit details
Commits on Dec 7, 2023
-
Reallocated equipment retains turreted status
Comment out non-functioning crit loc snapshot code
Configuration menu - View commit details
-
Copy full SHA for 0e8d8a4 - Browse repository at this point
Copy the full SHA 0e8d8a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0aae89 - Browse repository at this point
Copy the full SHA b0aae89View commit details
Commits on Dec 9, 2023
-
Fix regression from b46d085 that inadvertently unset rear turret armor
This occurred during the `cmbTurret.setSelectedItem("Single Turret")` call after the `Load = false`, resulting in a call to `RecalcArmorLocations`. The fix is to remove these lines since they were redundant with the later call to `BuildTurretSelector` which properly sets `cmbTurret`.
Configuration menu - View commit details
-
Copy full SHA for b08ea43 - Browse repository at this point
Copy the full SHA b08ea43View commit details
Commits on Dec 11, 2023
-
Fix omnivehicle turrets and other related fixes
Omnivehicle turrets: - Turret tonnage from items now checked against max turret tonnage - Avoid unsetting turret tonnage for locked chassis (omni variants) - Ensure turret tonnage is kept in sync b/w UI and model - Copy rest of related code from wide UI to non-wide UI, including rear turret tonnage support Also: - Fix wide UI not resetting omni variant combobox when loading new vehicle - Fix changing from dual turrets to single turret not removing rear turret location
Configuration menu - View commit details
-
Copy full SHA for 90e41a7 - Browse repository at this point
Copy the full SHA 90e41a7View commit details -
Fix right sponson turret not being propagated to omni loadout
Also fix base loadout not referring to itself and rename SetTurretx to SetTurretxItems for clarity
Configuration menu - View commit details
-
Copy full SHA for f3da3d3 - Browse repository at this point
Copy the full SHA f3da3d3View commit details -
Fix omnivehicle rear turret tonnage limit not being saved/loaded
Also add rear turret armor and tonnage limit to HTML export
Configuration menu - View commit details
-
Copy full SHA for 5142633 - Browse repository at this point
Copy the full SHA 5142633View commit details -
Unlocking omni chassis no longer unchecks omni and zeros out turret t…
…onnages Also fix lock chassis button getting out of sync with omni checkbox
Configuration menu - View commit details
-
Copy full SHA for 5954475 - Browse repository at this point
Copy the full SHA 5954475View commit details -
Add color-coded turret tonnage limits and rear turret tonnage to info…
… bar To help make it fit in the info bar, turret tonnages are hidden if corresponding turret doesn't exist, and reduce width of some boxes there
Configuration menu - View commit details
-
Copy full SHA for 35a0523 - Browse repository at this point
Copy the full SHA 35a0523View commit details -
Move omnivehicle turret tonnage check to pre-save tonnage validation
Also improve validation error behavior a bit
Configuration menu - View commit details
-
Copy full SHA for 41d44a5 - Browse repository at this point
Copy the full SHA 41d44a5View commit details