Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful termination is implemented on Quarkus ShutdownEvent #11

Closed
ozangunalp opened this issue Dec 20, 2023 · 0 comments · Fixed by #18
Closed

Graceful termination is implemented on Quarkus ShutdownEvent #11

ozangunalp opened this issue Dec 20, 2023 · 0 comments · Fixed by #18
Assignees
@SravanThotakura05

Comments

@ozangunalp
Copy link
Collaborator

https://github.com/SolaceCoEExt/solace-quarkus/blob/76d9f4fe7052f2c4e5eff06ed9077de93036ca6f/pubsub-plus-connector/src/main/java/io/quarkiverse/solace/SolaceConnector.java#L84-L94

The waiting for message publishing or processing can happen on channel#close, which is called before the shutdown sequence on @BeforeDestroyed(ApplicationScoped.class) event.

Also, graceful shutdown needs some tests.
@SravanThotakura05 SravanThotakura05 self-assigned this Jan 5, 2024
@SravanThotakura05 SravanThotakura05 linked a pull request Jan 5, 2024 that will close this issue
Graceful shutdown #18
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SravanThotakura05 SravanThotakura05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Graceful shutdown SolaceLabs/solace-quarkus
2 participants
@ozangunalp @SravanThotakura05