Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread link information to ban data #36

Open
SocksTheWolf opened this issue Oct 14, 2023 · 5 comments
Open

Add thread link information to ban data #36

SocksTheWolf opened this issue Oct 14, 2023 · 5 comments
Labels
enhancement New feature or request tag-specific Only applies to the instance ran by TAG
Milestone

Comments

@SocksTheWolf
Copy link
Owner

Specifically, this should add either a new few columns into the banned accounts table or should be an entire separate table.

The goal of this is to populate the information with links to report threads (store a list of thread ids, not the actual links). The bot can resolve those thread ids when it generates said embed data.

@SocksTheWolf SocksTheWolf added enhancement New feature or request tag-specific Only applies to the instance ran by TAG labels Oct 14, 2023
@SocksTheWolf SocksTheWolf added this to the Version 2 milestone Oct 14, 2023
@user4752
Copy link
Contributor

once #39 has been confirmed, this can be easily done in a v3 database migration and can be done in multiple ways;

one example is a basic one-to-many table with a relationship between an entry in the ban table referencing a discord user id to a thread id, with multiple entries, one per unique thread / reporter.

Depending on intentions this can be a forced relationship, thus requiring a ban to exist prior to the linked threads, or a separate object which would allow reported thread ids to be referenced to a user id without a ban needing to exist.

@SocksTheWolf
Copy link
Owner Author

Based on potential usage cases so far, I think an implementation would not require the userid in question to be on the ban list, as we could have suspicious reports about a user without them being banned.

@user4752 user4752 mentioned this issue Oct 31, 2023
@user4752
Copy link
Contributor

With remote reporting with evidence now available, and the data being posted into ConfigData['ReportChannel'] via BotMain: PostScamReport(), is this issue still something which needs to be stored in the database?

@SocksTheWolf
Copy link
Owner Author

I think this would still be good to be able to present information on the scammers and would also increase trust among server operators.

@SocksTheWolf SocksTheWolf removed this from the Version 2 milestone May 24, 2024
@SocksTheWolf
Copy link
Owner Author

I think when we register a ban, we're going to just add the field to the ban object, and then can create a discord snowflake link to the channel thread for more information. We can add that object to any ban embed that's created. The thread itself can be pulled from the interaction during a ban approve.

@SocksTheWolf SocksTheWolf added this to the Version 2.5 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tag-specific Only applies to the instance ran by TAG
Projects
None yet
Development

No branches or pull requests

2 participants