Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO events #46

Open
ttimot24 opened this issue Sep 16, 2024 · 1 comment
Open

AVRO events #46

ttimot24 opened this issue Sep 16, 2024 · 1 comment

Comments

@ttimot24
Copy link
Contributor

Is there a way to configure this SPI to produce AVRO events into the topic?

ttimot24 added a commit to ttimot24/keycloak-kafka-events that referenced this issue Sep 16, 2024
SnuK87 added a commit that referenced this issue Sep 17, 2024
#46 - Added AVRO serializer to the plugin
@SnuK87 SnuK87 closed this as completed Sep 18, 2024
ttimot24 added a commit to ttimot24/keycloak-kafka-events that referenced this issue Sep 18, 2024
@ttimot24
Copy link
Contributor Author

ttimot24 commented Sep 18, 2024

@SnuK87 I just found out that some other modifications also needed. First of all there is a org.apache.kafka.common.serialization.Serializer which can be implemented instead explicitly call object mapper and publish events as a string.

Furthermore optionalProperties does not hold any value since the ProducerConfig initialized later. Because of this AVRO serializer class can not be configured from config.

I'm going to create some pull requests in the following days. If you don't have time for this project I would be glad to become the maintainer of this repo, since I work with Kafka and Keycloak all the time.

I recommend to delete 1.2.0 release and release again after I fixed the optionalProperties.

Anyway thank you so much for this SPI. It is really needed out there.

@SnuK87 SnuK87 reopened this Sep 18, 2024
ttimot24 added a commit to ttimot24/keycloak-kafka-events that referenced this issue Sep 20, 2024
ttimot24 added a commit to ttimot24/keycloak-kafka-events that referenced this issue Sep 20, 2024
ttimot24 added a commit to ttimot24/keycloak-kafka-events that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants