-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Terraform import of snowflake_tag_association is not working correctly #3145
Comments
Hey @saugandhik-kipi. Thanks for reaching out to us. @sfc-gh-jmichalak is currently working on the tags redesign, so he will check this issue during that work. |
++ @***@***.*** ***@***.***>
…On Mon, Oct 21, 2024 at 7:20 PM Artur Sawicki ***@***.***> wrote:
Hey @saugandhik-kipi <https://github.com/saugandhik-kipi>. Thanks for
reaching out to us.
@sfc-gh-jmichalak <https://github.com/sfc-gh-jmichalak> is currently
working on the tags redesign, so he will check this issue during that work.
—
Reply to this email directly, view it on GitHub
<#3145 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKQ3OVYZVASGXXJQ5BF5R23Z4UBCPAVCNFSM6AAAAABQKBNCWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRWG42DINJZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
<!-- Feel free to delete comments as you fill this in --> - rework `tag_association` resource - return `nil` from GetTag instead of failing - add more tests regarding tag/masking policy: assert that `ALTER MASKING POLICY SET TAG` differs from `ALTER TAG SET MASKING POLICY` - support tagging account for identifiers with org name - support `IF EXISTS` for unsetting tags - add notes about manually unassigning policies from objects, add a todo with an issue number - fix a wrong issue number in essential objects list <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> https://docs.snowflake.com/en/user-guide/object-tagging https://docs.snowflake.com/en/sql-reference/functions/system_get_tag #3145 #1910 #2943 #3235 ## TODO - use generated config and asserts, remove old test `tf` files ## Ideas - extract a separate resource for tagging accounts?
Hi @saugandhik-kipi 👋 We've just released v0.100.0 (release, migration guide) in which we reworked tag associations. Please mind the limitations: Please upgrade to this version and let us know if you have any issues. |
Terraform CLI Version
1.9.8
Terraform Provider Version
0.97.0
Terraform Configuration
Category
category:resource
Object type(s)
No response
Expected Behavior
expected would be all the attributes should have value like below -
resource "snowflake_tag_association" "table_association" {
object_identifier {
name = snowflake_table.test.name
database = snowflake_database.test.name
schema = snowflake_schema.test.name
}
object_type = "TABLE"
tag_id = snowflake_tag.test.id
tag_value = "engineering"
}
Actual Behavior
{
"address": "module.tag.snowflake_tag_association.example",
"mode": "managed",
"type": "snowflake_tag_association",
"name": "example",
"provider_name": "registry.terraform.io/snowflake-labs/snowflake",
"schema_version": 0,
"values": {
"id": "ANALYTICS_PRODUCTION_DB.SNAPSHOTS.ON_CHURN_ARCHIVE.ANALYTICS_PRODUCTION_DB.SNAPSHOTS.PG__INSTITUTIONS_SNAPSHOT",
"object_identifier": [],
"object_name": null,
"object_type": null,
"skip_validation": null,
"tag_id": null,
"tag_value": null,
"timeouts": null
},
"sensitive_values": {
"object_identifier": []
}
}
],
"address": "module.tag"
},
Steps to Reproduce
Import any tag association in terraform state.
How much impact is this issue causing?
High
Logs
No response
Additional Information
Would you like to implement a fix?
The text was updated successfully, but these errors were encountered: