You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here is a few example when making values sensitive is pointless:
snowflake_user_ownership_grant on_user_name is sensitive yet ID contains user_name in plain text:
# snowflake_user_ownership_grant.users["EXAMPLE_USER"] will be updated in-place
~ resource "snowflake_user_ownership_grant" "users" {
id = "EXAPMLE_USER|USERADMIN|COPY"
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ on_user_name = (sensitive value)
# (3 unchanged attributes hidden)
}
For snowflake_role_grants users list is sensitive yet all of the users are present in the id as well:
# snowflake_role_grants.roles["EXAMPLE_ROLE"] will be updated in-place
~ resource "snowflake_role_grants" "roles" {
id = "EXAMPLE_ROLE|SYSADMIN|EXAMPLE_USER1,EXAMPLE_USER2,EXAMPLE_USER3"
~ users = (sensitive value)
# (3 unchanged attributes hidden)
}
I think changes in this PR do not serve any meaningful purpose and just make life harder.
First of all, why terraform should mark these values as sensitive when they are freely available in the Snowflake UI? Terraform plan is not a publicly available data, it is performed by a user with sufficient permissions so user can see all of this information in the UI as well.
Also, you don't see it in other providers - AWS doesn't set username of aws_iam_user as a sensitive value, Google doesn't mark user email as sensitive data in googleworkspace_user, etc.
Personally I want this change to be rollbacked, but even if you want to continue using such approach it doesn't serve its purpose right now.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Here is a few example when making values sensitive is pointless:
I think changes in this PR do not serve any meaningful purpose and just make life harder.
First of all, why terraform should mark these values as sensitive when they are freely available in the Snowflake UI? Terraform plan is not a publicly available data, it is performed by a user with sufficient permissions so user can see all of this information in the UI as well.
Also, you don't see it in other providers - AWS doesn't set username of aws_iam_user as a sensitive value, Google doesn't mark user email as sensitive data in googleworkspace_user, etc.
Personally I want this change to be rollbacked, but even if you want to continue using such approach it doesn't serve its purpose right now.
Beta Was this translation helpful? Give feedback.
All reactions