diff --git a/pkg/resources/tag_association_test.go b/pkg/resources/tag_association_test.go index 62015b1c7e..fc6509cac6 100644 --- a/pkg/resources/tag_association_test.go +++ b/pkg/resources/tag_association_test.go @@ -15,7 +15,7 @@ func TestTagIdentifierAndObjectIdentifier(t *testing.T) { in := map[string]any{ "tag_id": "\"test_db\".\"test_schema\".\"test_tag\"", "object_type": "ACCOUNT", - "object_identifier": []any{ + "object_identifiers": []any{ "orgname.accountname", }, } @@ -31,7 +31,7 @@ func TestTagIdentifierAndObjectIdentifier(t *testing.T) { in := map[string]any{ "tag_id": "\"test_db\".\"test_schema\".\"test_tag\"", "object_type": "DATABASE", - "object_identifier": []any{ + "object_identifiers": []any{ "test_db", }, } @@ -48,7 +48,7 @@ func TestTagIdentifierAndObjectIdentifier(t *testing.T) { in := map[string]any{ "tag_id": "\"test_db\".\"test_schema\".\"test_tag\"", "object_type": "SCHEMA", - "object_identifier": []any{ + "object_identifiers": []any{ "test_db.test_schema", }, } @@ -65,7 +65,7 @@ func TestTagIdentifierAndObjectIdentifier(t *testing.T) { in := map[string]any{ "tag_id": "\"test_db\".\"test_schema\".\"test_tag\"", "object_type": "TABLE", - "object_identifier": []any{ + "object_identifiers": []any{ "test_db.test_schema.test_table", }, } @@ -82,7 +82,7 @@ func TestTagIdentifierAndObjectIdentifier(t *testing.T) { in := map[string]any{ "tag_id": "\"test_db\".\"test_schema\".\"test_tag\"", "object_type": "COLUMN", - "object_identifier": []any{ + "object_identifiers": []any{ "test_db.test_schema.test_table.test_column", }, } @@ -99,7 +99,7 @@ func TestTagIdentifierAndObjectIdentifier(t *testing.T) { in := map[string]any{ "tag_id": "\"test_db\".\"test_schema\".\"test_tag\"", "object_type": "COLUMN", - "object_identifier": []any{ + "object_identifiers": []any{ "\"", }, } @@ -112,7 +112,7 @@ func TestTagIdentifierAndObjectIdentifier(t *testing.T) { in := map[string]any{ "tag_id": "\"test_schema\".\"test_tag\"", "object_type": "DATABASE", - "object_identifier": []any{ + "object_identifiers": []any{ "test_db", }, } diff --git a/pkg/sdk/tags_test.go b/pkg/sdk/tags_test.go index 38eb3edcb7..0a9046ab78 100644 --- a/pkg/sdk/tags_test.go +++ b/pkg/sdk/tags_test.go @@ -377,12 +377,6 @@ func TestTagSet(t *testing.T) { assertOptsInvalidJoinedErrors(t, opts, errors.New("tagging for object type SEQUENCE is not supported")) }) - t.Run("validation: unsupported account", func(t *testing.T) { - opts := defaultOpts() - opts.objectType = ObjectTypeAccount - assertOptsInvalidJoinedErrors(t, opts, errors.New("tagging for object type ACCOUNT is not supported - use Tags.SetOnCurrentAccount instead")) - }) - t.Run("set with all optional", func(t *testing.T) { opts := defaultOpts() opts.SetTags = []TagAssociation{ @@ -406,7 +400,7 @@ func TestTagSet(t *testing.T) { }, }, } - assertOptsValidAndSQLEquals(t, opts, `ALTER %s %s SET TAG "tag1", "tag2"`, opts.objectType, accountId.FullyQualifiedName()) + assertOptsValidAndSQLEquals(t, opts, `ALTER %s %s SET TAG "tag1" = 'value1'`, opts.objectType, accountId.FullyQualifiedName()) }) t.Run("set with column", func(t *testing.T) { diff --git a/v1-preparations/REMAINING_GA_OBJECTS.MD b/v1-preparations/REMAINING_GA_OBJECTS.MD index fae960f8d3..97f8f7bade 100644 --- a/v1-preparations/REMAINING_GA_OBJECTS.MD +++ b/v1-preparations/REMAINING_GA_OBJECTS.MD @@ -22,7 +22,7 @@ Known issues lists open issues touching the given object. Note that some of thes | EXTERNAL ACCESS INTEGRATION | ❌ | [#2546](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2546) | | FAILOVER GROUP | ❌ | [#2516](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2516), [#2332](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2332), [#1418](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1418) | | MANAGED ACCOUNT | ❌ | - | -| NOTIFICATION INTEGRATION | ❌ | [#2966](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2966), [#2965](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2965), [#1051](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1051) | +| NOTIFICATION INTEGRATION | ❌ | [#3138](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/3138), [#2966](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2966), [#2965](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2965), [#1051](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1051) | | REPLICATION GROUP | ❌ | [#1602](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1602) | | SHARE | ❌ | [#3051](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/3051), [#2189](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2189), [#1279](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1279), [#630](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/630) | | STORAGE INTEGRATION | ❌ | [#3082](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/3082), [#2624](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2624), [#1445](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1445) |