Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://linear.app/snapchain/issue/SNA-574/op-chain-deployment-fix-explorer-favicon
fix the favicon to display our own logo instead of blcokscout's
https://github.com/blockscout/frontend/blob/main/docs/ENVS.md#favicon said
FAVICON_MASTER_URL
usesNEXT_PUBLIC_NETWORK_ICON
as the default value but it's still showing blockscout. manually settingFAVICON_MASTER_URL
doesn't work eitherroot cause:
per https://github.com/blockscout/frontend/releases/tag/v1.36.0
Test Plan
run
docker logs -n 100 -f frontend
before:
after:
run
make l2-explorer-restart
to redeploy. see https://explorer.tohma.snapchain.dev/ to verify