Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block explorer favicon #45

Merged
merged 1 commit into from
Nov 30, 2024
Merged

fix: block explorer favicon #45

merged 1 commit into from
Nov 30, 2024

Conversation

bap2pecs
Copy link
Member

Summary

https://linear.app/snapchain/issue/SNA-574/op-chain-deployment-fix-explorer-favicon

fix the favicon to display our own logo instead of blcokscout's

https://github.com/blockscout/frontend/blob/main/docs/ENVS.md#favicon said FAVICON_MASTER_URL uses NEXT_PUBLIC_NETWORK_ICON as the default value but it's still showing blockscout. manually setting FAVICON_MASTER_URL doesn't work either

root cause:

per https://github.com/blockscout/frontend/releases/tag/v1.36.0

blockscout/frontend#2319 - ⚠️ FAVICON_GENERATOR_API_KEY has been removed due to the migration to a Node.js library solution

Test Plan

run docker logs -n 100 -f frontend
before:

🌀 Generating favicons bundle...
🛑 Error: FAVICON_GENERATOR_API_KEY variable is not provided.
👎 Unable to generate favicons bundle.

after:

Generating favicons...
Favicons generated successfully!
⏳ Replacing default favicons with freshly generated pack...
👍 Favicons bundle successfully generated.

run make l2-explorer-restart to redeploy. see https://explorer.tohma.snapchain.dev/ to verify

@bap2pecs bap2pecs requested a review from a team as a code owner November 29, 2024 07:41
@bap2pecs bap2pecs merged commit 3ac633b into main Nov 30, 2024
1 check passed
@bap2pecs bap2pecs deleted the fix/favicon branch November 30, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant