Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minting NFT by attestation when type of ticketID is string #253

Open
oleggrib opened this issue May 4, 2022 · 0 comments
Open

Minting NFT by attestation when type of ticketID is string #253

oleggrib opened this issue May 4, 2022 · 0 comments
Assignees

Comments

@oleggrib
Copy link
Collaborator

oleggrib commented May 4, 2022

few month ago we updated ticket schema to allow ticketId as string. #221

so new tickets can be passed for minting to the SmartContract. so we need updated validationContract to allow string if someone use ticketId as string. For compatability we can return numbers as strings too. @JamesSmartCell, cound you update validation contract?

currently we can use existing contract and dont let users to use ticketID as string, so it will not affect current projects

Current smartContract logic: NFT_ID = ticketID + OpenZeppelin enumerable, but I am going to update it.

  • NFT_IDs will be increasing
  • I will add relation NFT_ID->ticketId
  • optimized enumeration

@AW-STJ , @nicktaras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants