Filter unlocked researches of player #3996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you first researched an item then disabled it you would still have the research. Sf stats however doesn't count researches without any enabled items for the total amount of researches. This means you could have more researches unlocked then the 'total'. This resulted in a fraction >1, thus an index >= titels.size, thus throwing an
IndexOutOfBounds
exception.Proposed changes
Also filter the unlocked researches of the player to only include researches with at least 1 enabled item.
Related Issues (if applicable)
Resolved #3995
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values