Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter unlocked researches of player #3996

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

iTwins
Copy link
Contributor

@iTwins iTwins commented Oct 11, 2023

Description

When you first researched an item then disabled it you would still have the research. Sf stats however doesn't count researches without any enabled items for the total amount of researches. This means you could have more researches unlocked then the 'total'. This resulted in a fraction >1, thus an index >= titels.size, thus throwing an IndexOutOfBounds exception.

Proposed changes

Also filter the unlocked researches of the player to only include researches with at least 1 enabled item.

Related Issues (if applicable)

Resolved #3995

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@iTwins iTwins requested a review from a team as a code owner October 11, 2023 20:02
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Oct 11, 2023
@github-actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@github-actions
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: c418140a

https://preview-builds.walshy.dev/download/Slimefun/3996/c418140a

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Very nice

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WalshyDev WalshyDev merged commit 5f9da5b into Slimefun:master Dec 5, 2023
14 checks passed
@iTwins iTwins deleted the fix/sf_stats branch December 5, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command /sf stats doesnt work in some cases
4 participants