-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Commands #3935
base: master
Are you sure you want to change the base?
Cleanup Commands #3935
Conversation
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/3935/0c9c8d8b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw you missed these. Also SlimefunTabCompleter.java had some annotations that I couldn't comment on.
I think this looks a lot cleaner than it did before.
src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/SlimefunTabCompleter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/GiveCommand.java
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/GiveCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/BackpackCommand.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/TeleporterCommand.java
Outdated
Show resolved
Hide resolved
I completely forgot about this whoops, I'll actually work on this today |
(Could I get some reviews and testing on this) |
Needs rebase |
I tested this on a version that doesnt break heads. |
Can we get a rebase here? |
Description
This PR is made to cleanup all of the command classes & make them more readable, after this PR a PR could be opened to abstract a lot of these checks to further improve the state of the command classes, I am leaving that separate to avoid going out of scope and make it more manageable. Blame Jeff for the opening of this PR 👍
Proposed changes
Change almost all Command classes to use more guard statements, add missing annotations, and just general cleanup. This PR does go against the code style guidelines, discuss in developers chat
Related Issues (if applicable)
N/A
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values