-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added bamboo to the saw table #3878
added bamboo to the saw table #3878
Conversation
Your Pull Request was automatically labelled as: "🎈 Feature" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/3878/e9f702c9
|
bamboo blocks / stripped bamboo blocks are tagged in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this completely, my bad
This cant be merged |
Bukkit what the fuck |
i dont see how this is broken also it doesnt work on what ever version... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code wise, want to test to make sure everything is correct tho
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/multiblocks/TableSaw.java
Show resolved
Hide resolved
Bumping this: are there new bamboo things now? Is the tag fixed now? |
nope the tag is still null |
nvm this seems to be a mockbukkit issue. |
Description
added bamboo to the saw table
Proposed changes
Added bamboo blocks > bamboo plank
and
Stripped bamboo blocks > bamboo plank
in the saw mil
Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values