Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bamboo to the saw table #3878

Closed

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Jun 29, 2023

Description

added bamboo to the saw table

Proposed changes

Added bamboo blocks > bamboo plank
and
Stripped bamboo blocks > bamboo plank
in the saw mil

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@J3fftw1 J3fftw1 requested a review from a team as a code owner June 29, 2023 16:56
@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Jun 29, 2023
@github-actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: e9f702c9

https://preview-builds.walshy.dev/download/Slimefun/3878/e9f702c9

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@SchnTgaiSpock
Copy link
Contributor

SchnTgaiSpock commented Jun 29, 2023

bamboo blocks / stripped bamboo blocks are tagged in Tag.BAMBOO_BLOCKS not Tag.LOGS

Sfiguz7
Sfiguz7 previously approved these changes Jul 11, 2023
Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this completely, my bad

@J3fftw1
Copy link
Contributor Author

J3fftw1 commented Jul 11, 2023

This cant be merged
for some reason bukkit thinks the tag is empty

@Sfiguz7 Sfiguz7 self-assigned this Jul 11, 2023
@Sfiguz7
Copy link
Member

Sfiguz7 commented Jul 11, 2023

Bukkit what the fuck
Is it a thing that was broken in 1.20.0 and fixed in 1.20.1, has it been reported to them at all, is there something else at play...? Do we know anything basically?

@J3fftw1
Copy link
Contributor Author

J3fftw1 commented Jul 11, 2023

i dont see how this is broken
Bukkit litteraly gets the tag from minecraft and turns it into theirs.

also it doesnt work on what ever version...

JustAHuman-xD
JustAHuman-xD previously approved these changes Aug 3, 2023
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise, want to test to make sure everything is correct tho

@Sfiguz7
Copy link
Member

Sfiguz7 commented Dec 7, 2023

Bumping this: are there new bamboo things now? Is the tag fixed now?

@J3fftw1
Copy link
Contributor Author

J3fftw1 commented Dec 10, 2023

nope the tag is still null

@J3fftw1
Copy link
Contributor Author

J3fftw1 commented Dec 10, 2023

nvm this seems to be a mockbukkit issue.
I can use the tag properly when i skip tests.
We really need to update mockbukkit

@J3fftw1 J3fftw1 closed this Dec 23, 2023
@J3fftw1 J3fftw1 deleted the feature/added-bamboo-too-sawtable branch December 23, 2023 20:09
@J3fftw1 J3fftw1 restored the feature/added-bamboo-too-sawtable branch February 25, 2024 17:26
@J3fftw1 J3fftw1 reopened this Feb 25, 2024
@J3fftw1 J3fftw1 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants