Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4209 #4270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #4209 #4270

wants to merge 1 commit into from

Conversation

alexsvorada
Copy link

@alexsvorada alexsvorada commented Dec 10, 2024

Description

Fixes #4209

Proposed changes

Since update 1.19.3 changed the default spawner entity type from Pig to null, it's required to manually fall back to Pig entity type to maintain compatibility with features/addons that would never expect a null EntityType.

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@alexsvorada alexsvorada requested a review from a team as a code owner December 10, 2024 21:40
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@alexsvorada alexsvorada marked this pull request as draft December 10, 2024 21:42
@JustAHuman-xD JustAHuman-xD added the ✨ Fix This Pull Request fixes an issue. label Dec 11, 2024
@alexsvorada alexsvorada marked this pull request as ready for review December 11, 2024 12:19
@100petr
Copy link
Contributor

100petr commented Dec 11, 2024

Tested and the fix works – after mining an empty spawner, it turns into a broken pig spawner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty spawner error
3 participants