Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add permission check to SF Search in cheat mode #4266

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JustAHuman-xD
Copy link
Contributor

Description

In the unlikely event someone manages to get a cheat sheet they can cheat in items with the search feature, we don’t want that.

Proposed changes

Change the logic for search items to match the logic for normal items when clicked. (Have a permission check for cheating, cheat in stack when shifting)

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@JustAHuman-xD JustAHuman-xD requested a review from a team as a code owner November 19, 2024 19:44
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Nov 19, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link

sonarcloud bot commented Nov 19, 2024

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 1521755

https://preview-builds.walshy.dev/download/Slimefun/4266/15217555

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant