Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChargingBench can recharge muliple stackable items. #4183

Closed
4 tasks done
Intybyte opened this issue May 3, 2024 · 3 comments · Fixed by #4184
Closed
4 tasks done

ChargingBench can recharge muliple stackable items. #4183

Intybyte opened this issue May 3, 2024 · 3 comments · Fixed by #4184
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team. ✔ Resolved This Issue has been resolved.

Comments

@Intybyte
Copy link
Contributor

Intybyte commented May 3, 2024

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

To test this out I created a simple addon with a stackable item as the tool that needs to be recharged, I put a stack into the ChargingBench and it recharged them.

📑 Reproduction Steps

  1. Get yourself a stack of stackable rechargable items
  2. Throw them into the charging bench
  3. A stack worth of these items will recharge, effectively making charging bench +3200% more efficient

💡 Expected Behavior

  1. Don't recharge the ItemStack

📷 Screenshots / Videos

2024-05-03.18-56-01.mp4

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

Dev - 1145

🧭 Other plugins

Any addon, fixing this may allow addon creators more freedom over their Rechargeable items
@Intybyte Intybyte added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels May 3, 2024
This was referenced May 3, 2024
Closed
Merged
@Boomer-1 Boomer-1 added 🧨 Confirmed Bug This bug has been confirmed by our team. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels May 3, 2024
@Boomer-1
Copy link

Boomer-1 commented May 3, 2024

confirmed

@Boomer-1 Boomer-1 mentioned this issue Jun 27, 2024
Closed
4 tasks
@Boomer-1
Copy link

could be tied to #4212

@mcchampions
Copy link

could be tied to #4212

No.and you may add "?"

mcchampions added a commit to mcchampions/Slimefun4 that referenced this issue Jul 5, 2024
@mcchampions
Fix Slimefun#4183
7328627 
对于堆叠的可充电物品采取了逐一充电的方法
TheBusyBiscuit pushed a commit that referenced this issue Aug 8, 2024
@Intybyte @J3fftw1 @JustAHuman-xD
Fix ChargingBench (#4184)
2fd0f8a 
Resolves #4183
* Fix ChargingBench
- ChargingBench can now only recharge ItemStacks with 1 item.

---------

Co-authored-by: J3fftw <[email protected]>
Co-authored-by: JustAHuman-xD <[email protected]>
@TheBusyBot TheBusyBot added the ✔ Resolved This Issue has been resolved. label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team. ✔ Resolved This Issue has been resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ChargingBench Intybyte/Slimefun4-Fixes
4 participants
@TheBusyBot @Intybyte @Boomer-1 @mcchampions