Fix sensitive blocks attached to sf blocks not dropping (1.19+) #3966
Conversation
|
Your Pull Request was automatically labelled as: "✨ Fix" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/3966/f3861ebd
|
|
If it does now then it already did before this change. The only extra thing I do now is drop the items of sensitive blocks that get destroyed. Also the only 2 sensitive blocks in Slimefun are the elevator plate and teleportation matrix activator and those get handled by This new method could serve as the more inclusive replacement for |
| if (Slimefun.getMinecraftVersion().isAtLeast(MinecraftVersion.MINECRAFT_1_19)) { | ||
| return blockData.isSupported(block); | ||
| } else { | ||
| // TODO: Make 1.16-1.18 version. BlockData::isSupported is 1.19+. |
There was a problem hiding this comment.
is this todo for this PR or later?
There was a problem hiding this comment.
I wasn't planning on making that in this pr and I doubt anyone else will, so worst case scenario this is a fix for only 1.19+ and the version check can be removed when we drop support for 1.18.
There was a problem hiding this comment.
Im fine with that. We then have solved the issue for over 75% of the servers atleast
Sfiguz7
added
the
🎯 Needs testing
variananora
added
Build tested
Description
When you would break a Slimefun block any sensitive blocks attached to it would be destroyed, but not drop their item.
This fix only works for 1.19+, but that accounts for 4/5 of all Slimefun servers. Feel free to suggest a 1.16-1.18 version.
Proposed changes
Recursively check all attached sensitive blocks and drop them if they should be, while respecting
max-chained-neighbor-updatesinserver.properties.Related Issues (if applicable)
Resolves #3182
Resolves #3831
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values