-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes duplication glitch with explosive tools in combination with itemsadder #3940
Conversation
Your Pull Request was automatically labelled as: "✨ Fix" |
keeping this on draft for now. |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/3940/26543907
|
I tried the PR and the fix is as lone wrote PluginBugs/Issues-ItemsAdder#2777 (comment) - itemsadder blocks are skipped. Vanilla blocks are destroyed, itemsadder blocks are not and nothing drops from them. |
Sadly there doesnt seem to be away for us to actually drop the itemsadder block. This will be a sufficient fix for now. I do want to look into this more but that will be a follow up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause a ClassNotFoundException on every server that does not use ItemsAdder :NotLikeThis:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (as much as it can, im not familiar with itemsadder api so 🤷, but the code itself is fine)
Don't know if it's possible, but if it is wouldn't the 'right' place to handle this be in the integrations package? |
good catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, trusting the API to be correct I don't see any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM same as sfiguz
Description
This PR resolves a duplication glitch with the Items adder plugin and Slimefun.
Proposed changes
Disable blockbreak when its a custom block from items adder.
Related Issues (if applicable)
Resolves #3836
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values