Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when startin RateMyApp for native ratings #96

Closed
Arcturus5404 opened this issue Mar 22, 2021 · 2 comments
Closed

Exception when startin RateMyApp for native ratings #96

Arcturus5404 opened this issue Mar 22, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Arcturus5404
Copy link

Describe the bug
When calling the showRateDialog method with ignoreNativeDialog: false, an exception is being thrown:

E/flutter ( 6167): [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: type 'Future<bool?>' is not a subtype of type 'FutureOr' in type cast
E/flutter ( 6167): #0 RateMyApp.showRateDialog (package:rate_my_app/src/core.dart:128:46)
E/flutter ( 6167): #1 _StartScreenState._showRateMyApp (package:paintmaster/screens/start_screen.dart:342:24)
E/flutter ( 6167): #2 _StartScreenState.initState. (package:paintmaster/screens/start_screen.dart:335:9)
E/flutter ( 6167):

To Reproduce
Steps to reproduce the behavior:

  1. Call the method, see an exception

Expected behavior
No exceptions, I am not sure if the rate dialog works right now

Screenshots
The app runs fine though

@Arcturus5404 Arcturus5404 added the bug Something isn't working label Mar 22, 2021
@Arcturus5404
Copy link
Author

I think the fix is simple. The as Future<bool> should be Future<bool?>

@Skyost
Copy link
Owner

Skyost commented Mar 22, 2021

You're right, thanks for reporting !

@Skyost Skyost closed this as completed in b2033fc Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants