New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in TestDecodeBase58Address. #6

Open

vidya88 opened this issue Sep 20, 2019 · 1 comment

vidya88 commented Sep 20, 2019

@stdevAlDen commented on Jun 6

Describe the bug
Invalid use of SKY_base58_Hex2Base58 for binary data.

Environment information:

Platform: Any
Go environment: Any
Compiler info: Any

Steps to Reproduce
Steps to reproduce the behavior: Look at the following lines of code.

Actual behavior
SKY_base58_Hex2Base58 is receiving binary data.

Expected behavior
SKY_base58_Hex2Base58 should receive a hex buffer.

Author

vidya88 commented Sep 20, 2019

@stdevAlDen commented on Jun 12

@olemis & @stdevHan actually the SKY_base58_Hex2Base58 works with binary data not hex, so this should be fixed or the function name should be changed?
https://github.com/simelo/libskycoin/blob/5dec78d5434679bffc0f4d111a36518eb50a3e2b/lib/cgo/cipher.base58.base58.go#L22
https://github.com/skycoin/skycoin/blob/298181b47411117dcc8f6a09ab1e073b56e35a58/src/cipher/base58/base58.go#L46-L49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment