Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer unknown locale error #674

Open
Frostbyte0x70 opened this issue Dec 9, 2023 · 11 comments
Open

Installer unknown locale error #674

Frostbyte0x70 opened this issue Dec 9, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@Frostbyte0x70
Copy link
Member

Originally reported at https://discord.com/channels/710190644152369162/1183080667110703176

Seems like the SkyTemple 1.6.0 installer fails with certain locales.
Locale error

@theCapypara
Copy link
Member

Duplicate of #672

@theCapypara theCapypara marked this as a duplicate of #672 Dec 17, 2023
@Frostbyte0x70
Copy link
Member Author

Duplicate of #672

The error message is not the same, are we sure it's the same issue?

@theCapypara
Copy link
Member

ah, you are right. The error is not caught here. However I'm not really sure how to fix this, other than also just catching and ignoring the error. This seems to be an upstream Python bug, en_ID is a pretty new locale.

@theCapypara theCapypara reopened this Dec 18, 2023
@theCapypara theCapypara added the bug Something isn't working label Dec 18, 2023
@theCapypara theCapypara added this to 1.6 Dec 18, 2023
@theCapypara theCapypara marked this as not a duplicate of #672 Dec 18, 2023
@github-project-automation github-project-automation bot moved this to Done in 1.6 Dec 23, 2023
@Frostbyte0x70
Copy link
Member Author

Reopening this as there's been another report (https://discord.com/channels/710190644152369162/1246112469055967254)
Locale error

@Frostbyte0x70 Frostbyte0x70 reopened this May 31, 2024
@theCapypara
Copy link
Member

This is an dependency, we can't fix this.

@Frostbyte0x70
Copy link
Member Author

Not even by catching and ignoring the error as you said above?

@theCapypara
Copy link
Member

I don't think so at that point. the call is made by cairosvg to the builtin locale module, which just fails with this error. We could hot-patch locale. Maybe.
https://docs.python.org/3/library/locale.html

@theCapypara
Copy link
Member

I still can't find anybody else with this issue, and I don't really understand how the locale module is supposed to work under Windows. I don't really know where the actual issue is.

@Frostbyte0x70
Copy link
Member Author

A workaround has been found: https://discord.com/channels/710190644152369162/1259252798449651864
Maybe that can help clarify why the issue happens?

@theCapypara
Copy link
Member

The author of that thread changed their locale to a supported one.
Sure that is a workaround, but it doesn't really help, some Windows people would need to investigate this with Python and potentially raise an upstream bug with them or PyInstaller, depending on where the bug is.

@Frostbyte0x70
Copy link
Member Author

I see. Oh well, at least now we have proper instructions on what to do to avoid the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Status: Done
Development

No branches or pull requests

2 participants