Skip to content
This repository has been archived by the owner on Jan 2, 2022. It is now read-only.

Locraw outputs still are shown in the ReplayMod studio #86

Open
ChachyDev opened this issue Jun 3, 2021 · 2 comments
Open

Locraw outputs still are shown in the ReplayMod studio #86

ChachyDev opened this issue Jun 3, 2021 · 2 comments

Comments

@ChachyDev
Copy link
Contributor

Image of bug

None. Example output however:

{"server":"mini250J","gametype":"BEDWARS","mode":"BEDWARS_EIGHT_TWO","map":"Lightstone"}

Description

When using the ReplayMod ("RM") studio the locraw output is still shown. This is most likely because we only cancel the locraw message when the Player is active on Hypixel but not if they were in the RM studio...

How to reproduce?

  1. Load the game with Hytilities & RM
  2. Join the Hypixel Server mc.hypixel.net
  3. Use the mod for a decent amount of time, locraw should've been used once or twice by then
  4. Disconnect from Hypixel and go into Replay Videos
  5. Choose your latest Replay video
  6. Watch the replay and locraw messages appear in chat

Possible solutions

  • Detect for the ReplayStudio and cancel the locraw messages

Unsupported solutions

  • Prevent ReplayMod from picking up the chat packets containg locraw
@ghost
Copy link

ghost commented Jun 3, 2021

Johni suggests using !mc.isSingleplayer() && mc.getCurrentServerEntry() == null && !mc.isConnectedToRealms() to detect if it's a Replay world or not

@Wyvest
Copy link

Wyvest commented Jun 17, 2021

In my experience, Hytils Locraw just sometimes shows the output of locraw and sometimes doesn't

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants