Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Protontricks fail with python syntax error. #40

Open
sizeofbool opened this issue Dec 7, 2018 · 3 comments
Open

Protontricks fail with python syntax error. #40

sizeofbool opened this issue Dec 7, 2018 · 3 comments

Comments

@sizeofbool
Copy link

I think latest commit introduced a bug, which makes protontricks fail with python syntax error.

$ python3 -V
Python 3.5.3
$ ./protontricks
  File "./protontricks", line 364
    combo_values = "|".join([f'{app.name}: {app.appid}' for app in steam_apps])
                                                      ^
SyntaxError: invalid syntax
@Matoking
Copy link
Contributor

Matoking commented Dec 7, 2018

Python 3.5 doesn't support f-strings (introduced in 3.6).

The following should be compatible with the previous versions.

combo_values = "|".join([
    '{}: {}'.format(app.name, app.appid) for app in steam_apps
])

sizeofbool pushed a commit to sizeofbool/protontricks that referenced this issue Dec 7, 2018
@sizeofbool
Copy link
Author

#41

@sizeofbool
Copy link
Author

sizeofbool commented Dec 7, 2018

Python 3.5 doesn't support f-strings (introduced in 3.6).

I see, I thought it was a typo at first glance, now I know the true nature of it.
I've already created pull request with same fix.

Sirmentio added a commit that referenced this issue Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants