Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Fabric mods fail to load with cryptic errors if there is an invalid/corrupted Forge mod #701

Closed
Fuyukai opened this issue Jan 15, 2024 · 1 comment · Fixed by #692
Closed
Assignees
Labels
bug Something isn't working fixed in dev Fixed in dev. Awaiting a new release.

Comments

@Fuyukai
Copy link

Fuyukai commented Jan 15, 2024

Minecraft version

1.20.1

Describe the bug

All Fabric mods fail to load with cryptic errors if there is an invalid/corrupted Forge mod

Steps to reproduce

  1. Add a mod with broken metadata (e.g. mkdir META-INF; echo "[invalid]" > META-INF/mods.toml; zip testmod.zip -r META-INF)
  2. Add any Fabric mod to the instance
  3. Observe inability to find fabric-api despite Forgified Fabric API being installed.

Logs

https://gist.github.com/Fuyukai/f9bd7c60f1a86374495e36ddad94697c

Additional context

Crash does not happen if testmod.jar is disabled, or the Fabric mods are disabled (Forge gives the appropriate warning about an invalid mod). The actual Fabric mod in this case doesn't matter; I picked the first I could find on Modrinth with no forge version or other dependencies; I've had it explode in an instance full of them.

For a less contrived example that actually happens in the wild, Oculus mc1.20.1-1.6.13a triggers this bug due to having invalid metadata.

@Fuyukai Fuyukai added the bug Something isn't working label Jan 15, 2024
@Lolothepro
Copy link

Lolothepro commented Jan 15, 2024

probably a Forge/NeoForge bug

@Su5eD Su5eD self-assigned this Jan 15, 2024
@Su5eD Su5eD moved this from 🆕 New to 🔖 Confirmed in Connector Triage Jan 15, 2024
@Su5eD Su5eD moved this from 🔖 Confirmed to 🏗 In progress in Connector Triage Jan 18, 2024
@Su5eD Su5eD moved this from 🏗 In progress to 👀 In review in Connector Triage Jan 18, 2024
@Su5eD Su5eD linked a pull request Jan 18, 2024 that will close this issue
@Matyrobbrt Matyrobbrt added the fixed in dev Fixed in dev. Awaiting a new release. label Jan 20, 2024
@Su5eD Su5eD closed this as completed in 1f59e9a Jan 21, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Connector Triage Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Fixed in dev. Awaiting a new release.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants