Reporting modified methods/fields?

[melontini]

Hello, I found a few changed fields/methods, and I'm not sure what would be the correct way to report them and if some of them should be reported at all.

For example, method_29338()V in MinecraftClient became lambda$new$4(Lcom/mojang/realmsclient/client/RealmsClient;Lnet/minecraft/server/packs/resources/ReloadInstance;Lnet/minecraft/client/main/GameConfig;)V.

And the type of f_107293_ in ParticleEngine was changed from Int2ObjectMap<ParticleProvider<?>> to Map<ResourceLocation, ParticleProvider<?>>.

So, the game crashes with a NPE when I do something like this:

Minecraft.m_91087_().f_91061_.f_107293_.get(BuiltInRegistries.f_257034_.m_7447_(parameters.m_6012_())); //.mixin.out

MinecraftClient.getInstance().particleManager.factories.get(Registry.PARTICLE_TYPE.getRawId(parameters.getType())); //source

I'm not sure if changes like this are covered by Connector's transformers.

[Su5eD]

Right, we'll have to add transformers to translate the modified field types back to their original types when used. Adapter can handle reporting modified fields, but the transformers will have to be written manually.
After a quick scan, it found 10 fields in total:

Field net/minecraft/client/KeyMapping.f_90810_ changed its type from Ljava/util/Map; to Lnet/minecraftforge/client/settings/KeyMappingLookup;
Field net/minecraft/client/color/block/BlockColors.f_92571_ changed its type from Lnet/minecraft/core/IdMapper; to Ljava/util/Map;
Field net/minecraft/client/color/item/ItemColors.f_92674_ changed its type from Lnet/minecraft/core/IdMapper; to Ljava/util/Map;
Field net/minecraft/client/particle/ParticleEngine.f_107293_ changed its type from Lit/unimi/dsi/fastutil/ints/Int2ObjectMap; to Ljava/util/Map;
Field net/minecraft/world/entity/ai/goal/RangedBowAttackGoal.f_25782_ changed its type from Lnet/minecraft/world/entity/monster/Monster; to Lnet/minecraft/world/entity/Mob;
Field net/minecraft/world/item/HorseArmorItem.f_41362_ changed its type from Ljava/lang/String; to Lnet/minecraft/resources/ResourceLocation;
Field net/minecraft/world/item/alchemy/PotionBrewing$Mix.f_43532_ changed its type from Ljava/lang/Object; to Lnet/minecraft/core/Holder$Reference;
Field net/minecraft/world/item/alchemy/PotionBrewing$Mix.f_43534_ changed its type from Ljava/lang/Object; to Lnet/minecraft/core/Holder$Reference;
Field net/minecraft/world/level/storage/loot/LootDataType.f_278485_ changed its type from Ljava/util/function/BiFunction; to Lorg/apache/commons/lang3/function/TriFunction;
Field net/minecraft/world/level/storage/loot/LootTable.f_79109_ changed its type from [Lnet/minecraft/world/level/storage/loot/LootPool; to Ljava/util/List;