Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPubKey class and invalid pubkeys - should the API be changed ? #61

Open
dgpv opened this issue Nov 15, 2021 · 0 comments
Open

CPubKey class and invalid pubkeys - should the API be changed ? #61

dgpv opened this issue Nov 15, 2021 · 0 comments

Comments

@dgpv
Copy link

dgpv commented Nov 15, 2021

Start of the discussion is here: #60 (comment)

The question is, should we remove the (historically present, was in python-bitcoinlib) ability to create CPubKey instances from invalid pubkey data ?

If we do so, we should also remove is_fullyvalid() methods to avoid potential problems described in #60 (comment)

This will mean quite major API breakage, though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgpv