Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] Manage third party libs via composer #8240

Open
wants to merge 16 commits into
base: release-3.0
Choose a base branch
from
Open

[3.0] Manage third party libs via composer #8240

wants to merge 16 commits into from
+277 −3,849

Conversation

MissAllSunday
Copy link
Contributor

This is a simple POC for allowing SMF to handle their internal third party libraries via composer.

Some key features to take into consideration for this POC

  • Composer is solely used by SMF, that is, no access to mod authors. Mod authors can still ship their own vendor folder if they provide their respective configuration for it
  • Modifications to Simplemachines/build-tools will have to be made to further remove hardcoded instances of third party libs, happy to do those changes myself if required.
  • SMF release process will need to change to accommodate composer commands.

live627
live627 reviewed Jun 11, 2024
View reviewed changes
.scrutinizer.yml Outdated Show resolved Hide resolved
live627
live627 reviewed Jun 11, 2024
View reviewed changes
Sources/Config.php Outdated Show resolved Hide resolved
Sesquipedalian
Sesquipedalian requested changes Jun 24, 2024
View reviewed changes
index.php Outdated Show resolved Hide resolved
live627
live627 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@live627 live627 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working. Normal forum operations still work as expected.

@live627
Copy link
Contributor

live627 commented Dec 20, 2024

@MissAllSunday this is still marked as draft. You plan on more changes here?

@MissAllSunday
Copy link
Contributor Author

@MissAllSunday this is still marked as draft. You plan on more changes here?

Nope, will mark it as ready and resolve the conflicts

MissAllSunday and others added 16 commits December 24, 2024 11:01
@MissAllSunday
feat: include already used third parties on composer.json
a36172e
@MissAllSunday
feat: create new Config::$vendordir var
09baef7
@MissAllSunday
feat: remove references to third party in Sources files
64375e8
@MissAllSunday
feat: remove third party code in Sources
af0d7e4 
remove more calls to code in sources folder
@MissAllSunday
fix: revert changes to Sources/Unicode/Currencies.php
1ab8ccd
@MissAllSunday
feat: use composer autoloader for SMF namespace as well as third part…
f6579ea 
…y autoloads
@MissAllSunday
revert exploding $rowData['cur_perms']
36d454a
@MissAllSunday
remove function call
fd01e22
@MissAllSunday @live627
Update Sources/Config.php
e4c3334 
Co-authored-by: John Rayes <[email protected]>
@MissAllSunday @live627
Update .scrutinizer.yml
fbecb8a 
Co-authored-by: John Rayes <[email protected]>
@MissAllSunday
feat: move autoload functionality to its own file
31e878f
@MissAllSunday
feat: move autoload functionality to its own file
510c5e3
@MissAllSunday
feat: use vendor autoload on ExportProfileData.php
887065f
@MissAllSunday
feat: update autoload require
e00cf19
@MissAllSunday
fix: no need to include vendor folder on ignoring list
49b69e7
@MissAllSunday
fix: Revert changes to Currencies.php
82a164c
@MissAllSunday MissAllSunday marked this pull request as ready for review December 24, 2024 17:06
@MissAllSunday MissAllSunday changed the title POC: manage third party libs via composer [3.0] Manage third party libs via composer Dec 24, 2024
@live627
Copy link
Contributor

live627 commented Dec 25, 2024

Upon further testing, integrate_autoload doesn't work because it is called before settings are loaded. My fix live627@cfdfe79 should I submit this as another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@live627 live627 live627 approved these changes

@Sesquipedalian Sesquipedalian Awaiting requested review from Sesquipedalian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MissAllSunday @live627 @Sesquipedalian