Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webp support available in php 7.1+ #6545

Open
sbulen opened this issue Feb 27, 2021 · 7 comments
Open

webp support available in php 7.1+ #6545

sbulen opened this issue Feb 27, 2021 · 7 comments

Comments

@sbulen
Copy link
Contributor

sbulen commented Feb 27, 2021

Description

Add webp support.

Additional information/references

A support topic mentioned there was an issue logged - I don't think there is one, so just adding it.
https://www.simplemachines.org/community/index.php?topic=574576.msg4083346#msg4083346

@albertlast had a PR out there at one point:
#6271

@albertlast
Copy link
Collaborator

my pr got decllinded, so the problem is not real?

@MissAllSunday
Copy link
Contributor

MissAllSunday commented Feb 27, 2021

The already logged issue: #6271 a PR is considered an issue.

So far no one has come up with a valid reason as to why we need to add it other than "because google says so."

Post hard data on its usage across the web.

@albertlast
Copy link
Collaborator

when google with chrome, how got the major usage of browsers, say that webp is the next thing.
than had you show us why they lie.
give us hard data.

@MissAllSunday
Copy link
Contributor

I'm not the one making the proposal and I'm neither against nor in favor of it.

@sbulen
Copy link
Contributor Author

sbulen commented Feb 27, 2021

Current stats indicate 1.2% & growing.

Source:
https://w3techs.com/technologies/details/im-webp

I view it more an example of keeping current with php, as getimagesize now returns it as a valid image type.

@sbulen
Copy link
Contributor Author

sbulen commented Feb 27, 2021

The code would need to account for php 7.1 vs prior. The constant isn't defined in 7.0.

Lots of undefined constant issues out there due to improper implementation.

@sbulen
Copy link
Contributor Author

sbulen commented Mar 15, 2021

This is a good idea for a future release, but should not hold up RC4 or final.

@sbulen sbulen added this to the The future milestone Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants