Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMEAv4 tags: verify timestamp using the checksum. #71

Open
fabdrol opened this issue Dec 16, 2016 · 7 comments
Open

NMEAv4 tags: verify timestamp using the checksum. #71

fabdrol opened this issue Dec 16, 2016 · 7 comments
Milestone
1.0.0-alpha

Comments

@fabdrol
Copy link
Member

fabdrol commented Dec 16, 2016 •
edited
Loading

See #69
@fabdrol fabdrol modified the milestone: v1 Dec 16, 2016
@joabakk
Copy link
Contributor

joabakk commented Dec 17, 2016

It begs the question, what do we do if the checksum of the tag fails. We should probably discard the full sentence with tag and all, since defaulting to the system time may be a problem for logged data

@fabdrol fabdrol modified the milestones: 2.0, v1 Dec 18, 2016
@fabdrol
Copy link
Member Author

fabdrol commented Jan 15, 2017

Currently checksums aren't verified, and I'm not sure discarding the entire sentence is the best way to go. For logging, a notice in the log indicating the checksum problem could be a solution..

@joabakk
Copy link
Contributor

joabakk commented Jan 15, 2017

That works, I agree

@tkurki
Copy link
Member

tkurki commented Jan 15, 2017

FYI checksums are verified in master.

@fabdrol
Copy link
Member Author

fabdrol commented Jan 15, 2017

@tkurki checksums of tags?

@tkurki
Copy link
Member

tkurki commented Jan 15, 2017

Sorry, my mistake.

@fabdrol
Copy link
Member Author

fabdrol commented Jan 15, 2017

Np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha
Development

No branches or pull requests
3 participants
@fabdrol @tkurki @joabakk