Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coolant Pressure has incorrect value. #206

Open
pbegg opened this issue Nov 20, 2020 · 3 comments
Open

Coolant Pressure has incorrect value. #206

pbegg opened this issue Nov 20, 2020 · 3 comments

Comments

@pbegg
Copy link

pbegg commented Nov 20, 2020

Pulling engine data from an MAN engine, runs through a maretron J1939-N2K converter, out puts N2K pgn 127489.
My signalK data sources is showing coolant pressure to be 120000000, which I believe is wrong by a factor of 1000.

Looking at canboat/analyzer/pgn.h:

  • 'Oil Pressure' and 'Coolant Pressure' both have units of hPA

Looking at n2k-signalk/pgns/127489.js

  • Oil Pressure has just 'kPa'
  • Coolant Pressure has 'kPa * 1000'

removing the conversion factor of 1000 in coolant pressure should fix the issue. What I am missing is where in the process between canboat and signalk does the unit change from hPa to kPa?

I can create a pull request for the coolant pressure conversion factor to be removed in n2k-signalk/pgns/127489.js if this is the correct fix?

@tkurki
Copy link
Member

tkurki commented Feb 14, 2024

@sbender9 any thoughts?

@sbender9
Copy link
Member

Yeah. This sounds right. We should remove the * 1000

@philbegg
Copy link

What is the correct fix for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants