Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 EOL #286

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Python 3.8 EOL #286

merged 6 commits into from
Oct 14, 2024

Conversation

frack113
Copy link
Member

https://devguide.python.org/versions/

As 3.8 is finally at the end of life, I remove it

Did NOT edit the release.yml :

  • actions/setup-python@v4 -> v5
  • python-version: 3.8 -> 3.9 ?

Test faild with Python 3.13, I haven't dug yet

@frack113 frack113 requested a review from thomaspatzke October 11, 2024 05:04
@thomaspatzke thomaspatzke changed the title Python 38 eol Python 3.8 EOL Oct 13, 2024
@thomaspatzke
Copy link
Member

Still struggling on this:

  • Pro: no dependency on EOL Pythons.
  • Pro: new features can be used. There were several occasions where I wrote less nice code just for the 3.8 compatibility. These could now be rewritten. Sticking on old Pythons would block progress.
  • Against: Lots of stuff depends on EOL Pythons, e.g. Ubuntu LTS like 20.04 (but newer installable), Splunk (lost anyways, they use 3.7!).

I tend to Pro and merge. What do you think?

@branchvincent
Copy link
Contributor

fyi #289 presumably fixes the 3.13 test failures

@frack113
Copy link
Member Author

Hi,
for splunk "Beginning in Splunk Enterprise version 9.3, Splunk supports Python version 3.9 by default."
If we keep 3.8, we'll have to keep the other unsupported stuff, because an editor won't make the effort.
I'm more in favor of making the effort to be compatible 3.9 to 3.13

@thomaspatzke
Copy link
Member

Ok, let's do it this way!

Copy link
Member

@thomaspatzke thomaspatzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the deployment/publish flow to a newer one?

@frack113
Copy link
Member Author

Can be Squash and merge, too many commit to make a simple change 😄

@frack113 frack113 requested a review from thomaspatzke October 14, 2024 17:29
@thomaspatzke thomaspatzke merged commit 1ac3569 into SigmaHQ:main Oct 14, 2024
12 checks passed
@frack113 frack113 deleted the python_38_eol branch October 14, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants