-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha, beta correction for alignment rorations is alway positive number #32
Comments
It is mathematically only possible to determine the sign of alpha * beta. Practically maybe not even that due to finite resolution in the slope fit. Thats why I recommended to optimize the slopes to 0 with a generic minimizer. |
The fourth formular can be used to determine the sign, as it is also implemented here. |
BTW: if only one angle is rotated the result is the same independent of the alpha, beta sign. It is not the goal to reconstruct correct angles, but to get angles that minimize the residuals. |
so the minimizer should not get a alpha and beta prediction as a start value since this would bias the result. It should just guess which is the minimum residual for alpha and beta (and z) for each iteration and return the result whether it is positive or negative. In my opinion the angles are very much under control since I fixed the binning to give good fit results. But still then, alpha and beta are always positive which gives me some worries. |
Sure, 0s as start values are better than wrong start values. To write this minimizer is very straight forward but I have to measure right now. |
I never observed a negative number for alpha and beta correction. Thus the angle is increased every iteration and makes the residuals worse.
The text was updated successfully, but these errors were encountered: