Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha, beta correction for alignment rorations is alway positive number #32

Open
laborleben opened this issue Jul 30, 2016 · 5 comments
Labels

Comments

@laborleben
Copy link
Collaborator

I never observed a negative number for alpha and beta correction. Thus the angle is increased every iteration and makes the residuals worse.

@laborleben laborleben added the bug label Jul 30, 2016
@laborleben laborleben changed the title alpha, beta correction alway positive alpha, beta correction alway positive number Jul 30, 2016
@DavidLP
Copy link
Collaborator

DavidLP commented Aug 1, 2016

It is mathematically only possible to determine the sign of alpha * beta. Practically maybe not even that due to finite resolution in the slope fit. Thats why I recommended to optimize the slopes to 0 with a generic minimizer.

@DavidLP
Copy link
Collaborator

DavidLP commented Aug 1, 2016

The fourth formular can be used to determine the sign, as it is also implemented here.

capture

@DavidLP
Copy link
Collaborator

DavidLP commented Aug 1, 2016

BTW: if only one angle is rotated the result is the same independent of the alpha, beta sign. It is not the goal to reconstruct correct angles, but to get angles that minimize the residuals.

@laborleben
Copy link
Collaborator Author

so the minimizer should not get a alpha and beta prediction as a start value since this would bias the result. It should just guess which is the minimum residual for alpha and beta (and z) for each iteration and return the result whether it is positive or negative.

In my opinion the angles are very much under control since I fixed the binning to give good fit results. But still then, alpha and beta are always positive which gives me some worries.

@DavidLP
Copy link
Collaborator

DavidLP commented Aug 1, 2016

Sure, 0s as start values are better than wrong start values. To write this minimizer is very straight forward but I have to measure right now.

@DavidLP DavidLP changed the title alpha, beta correction alway positive number Alpha, beta correction for alignment rorations is alway positive number Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants