Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer v3.0.1 seems broken #84

Open
LucaSaraCzudar opened this issue Apr 27, 2023 · 6 comments
Open

Transformer v3.0.1 seems broken #84

LucaSaraCzudar opened this issue Apr 27, 2023 · 6 comments

Comments

@LucaSaraCzudar
Copy link

The controls are being displayed but I cannot interact with them, even on hover the cursor wouldn't change. I tried it with all kinds of settings. The same code works perfectly with v3.0.0

@khanzzirfan
Copy link

Hey Team , great work with upgrading the V7, specially the pixi-transformer. I was long waiting for that..
But not sure if the transformer is tested with the @pixi/react package. Currently its not working. Seems like the codepen created example works with only v5 @inlet/pixi react.
Can someone help with @pixi/react and transformer. I created a simple codesandbox if it helps.
https://codesandbox.io/s/react-pixi-text-image-sprite-transformer-v3-dt8rip

Seems like all the Events are null for the transformer object.
image

@ShukantPal
Copy link
Owner

The React helper package wasn’t designed for the new @pixi/react package. I would be happy to accept a PR that makes it work with the latest version (@pixi/react)

@SampsaKaskela
Copy link
Contributor

@pixi/react is pretty much has the same API as @inlet/pixi-react. The package name changed because Pixi team took over the project. It was made compatible with Pixi 7 and React 18 in the process. I copied the code from react-bindings package and just switched @inlet/pixi-react references with @pixi/react and it seemed to work for me. Got some peer dependency warnings tho so would probably be breaking change to react-bindings package since React version would have to be updated from 16 to 18.

Not sure about this codepen tho since it uses custom way to bind the Transformer while the usual way is to use PixiComponent utility from @pixi/react (docs: https://pixijs.io/pixi-react/custom-component/) which react-bindings package also uses to create Transformer.

@khanzzirfan
Copy link

Hey @SampsaKaskela , thank you for the update, wonder if you would be able to raise the PR for the react-bindings?

@SampsaKaskela
Copy link
Contributor

@khanzzirfan Just opened PR #91 although not sure how versioning should be handled there. Probably breaking change.

@ShukantPal
Copy link
Owner

Hi, just checking if this was fixed. That PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants