-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track GC stats #276
Comments
Does
I want to minimize the number of things we display on the front page because IMO it helps to focus attention to key metrics rather than overwhelm people with tons of graphs. I would also prefer for speed.yjit.org to remain primarily focused on YJIT rather than a generic tool to benchmark and track everything, because my experience is that trying to accommodate every possible use case only leads to a worse product.
I think this makes the most sense. The over time view could probably use some UI improvements, but it seems logical that we should be able to plot any of the stats/metrics that we have over time. |
Yes,
We can grab that when we get the YJIT runtime stats |
Agreed, we certainly don't need a new front page graph for this, just something on the details or history pages. |
We should update the harness to collect
GC.stat(:time)
and possibly:minor_gc_count
,:major_gc_count
, and maybe things liketotal_allocated_objects
@tenderworks observed that at the start of
3.4.0dev
the chunkypng was spending about 100ms in GC.On the latest master (around "b182f2a04520a0138992b27f9e6bfd15bdfd6f96") it is spending 130ms in GC.
We should decide if there's anything else we'd like to add to the harness and start collecting the data.
Then we can decide how we might want to visualize it:
gc time
in any of our other calculations?We already have an "over time" view of some of the yjit stats:
https://speed.yjit.org/stats-timeline.html#side_exits+overall-mean+activerecord+liquid-render+optcarrot+railsbench
Maybe we'd want to add this to that list.
The text was updated successfully, but these errors were encountered: