-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Checkout UI] useApplyCartLinesChange hook triggers contact and shipping address form validlation #2069
Comments
@theindra Can you clarify what |
👋 Thanks for reporting and supplying with example code! We'll triage this and take a look. |
@jun-shop Yes, can you provide an update? I was told by one of our Shopify contacts that this was "as designed" but this is something that changed recently. And customers/merchants are complaining about this as well. I understand the need to run the validation, but if the customer hasn't actually input anything or clicked through the checkout flow at all, this validation should not be happening, in my opinion. |
@jun-shop @theindra Can you provide an update on this ticket? This has a negative customer experience at checkout for any merchant that uses a Checkout Extension that modifies the cart. I was told by our Shopify contact that this was "as designed" but this hasn't always been the case. We have specific merchants that have complained about this and do not want to use checkout extensions until this is resolved. Can you increase the priority of this issue or give us an ETA on when this could be resolved? |
The team is actively investigating and working on a fix. Thank you for your patience and apologies for the delay |
@jun-shop do you have an ETA or a workaround for merchants in the meantime? As we approach crunch time, some issues we may need to consider ways we can unblock migrating shops. |
@francispelland It appears that this has been fixed. We were told by one of our Shopify contacts that it was resolved and validated it both on one of our test stores and a store that was live with our extension. |
Thank you for your patience. Closing this out, but please re-open if it happens again |
Hey team! I have a merchant that experienced this issue back in July and is reaching out again as it appears to have come back. Any insights on this would be greatly appreciated. |
Want to touch base to see if this has gotten eyes? |
Please list the package(s) involved in the issue, and include the version you are using
Describe the bug
When a cart line item is added or removed from the cart at checkout, the Contact and Shipping address form validation executes and the user is presented with validation errors on Email and Zip / postal code, e.g.
"Enter a valid email or a mobile phone number"
. This looks to be specific to theuseApplyCartLinesChange
hook. This also appears to be a more recent issue in the past day or two as we did not see this behavior with our app extensions until today.Steps to reproduce the behavior:
Expected behavior
The item should get added to the cart, and no form validation errors should be presented to the user.
Screenshots
Additional context
Some simple code that recreated this error:
The text was updated successfully, but these errors were encountered: