Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to remove attribute #1059

Open
patryk-smc opened this issue Jul 6, 2023 · 20 comments
Open

Ability to remove attribute #1059

patryk-smc opened this issue Jul 6, 2023 · 20 comments
Labels
enhancement New feature or request

Comments

@patryk-smc
Copy link

patryk-smc commented Jul 6, 2023

Please list the related package(s)

  • @shopify/checkout-ui-extensions-react

If this related to specific APIs or components, please list them here

  • AttributeUpdateChange / useApplyAttributeChange

Is your feature request related to a problem? Please describe.

Currently AttributeUpdateChange is missing a method for deleting an attribute. It can only add/update attributes.

Describe the changes you are looking for

I need to be able to delete attributes.

Describe alternatives you’ve considered

I tried passing an empty string but it creates an attribute with empty string.

@patryk-smc patryk-smc added the enhancement New feature or request label Jul 6, 2023
@julien-mamalian
Copy link

This is really a pain point for all developers that need to use note_attributes for their merchants. Right now, we need to create webhook to check for empty note_attributes and remove them.

@mj991218
Copy link

checkout attributes is a useful when need to be commnuicated between checkout extension on different page but no need to show on admin order page.
So useApplyAttributeChange hook need to have delete attribute as well.
While using cart ajax api, cart attribute' key is removed when set null value to the key. but it doesn't work on useApplyAttributeChange hook

@adamcharvat
Copy link

adamcharvat commented Mar 7, 2024

This is 100% needed, it is causing us a lot of pain as we now need to set the attribute to an empty strings when it shouldn't be there at all.

With the attribute still being present, we're having issues when working with other integrations and apps.

Is there really no workaround atm?

@thohot303
Copy link

plus one

1 similar comment
@LouiseEH
Copy link

LouiseEH commented Apr 4, 2024

plus one

@stefano-tonanni
Copy link

stefano-tonanni commented Apr 16, 2024

less than 4 months to the switch off of the custom checkout, and still missing basic features like that...
Fun fact: using cart ajax API from frontend, actually delete attributes if they are set to empty string :| MEH

@muchisx
Copy link

muchisx commented Apr 29, 2024

We really need this, there's a lot of checkout attributes we need dynamicalled added/removed so merchants can print the order slip and have it show up correctly

@Ciull0
Copy link

Ciull0 commented May 14, 2024

plus one

@Job-madi
Copy link

++

2 similar comments
@ksyp-7
Copy link

ksyp-7 commented May 17, 2024

++

@yossix
Copy link

yossix commented Jun 5, 2024

++

@tystar86
Copy link

tystar86 commented Jun 6, 2024

Can't believe it was proposed 11 months ago and still nothing. Shopify is pushing everyone really hard on checkout extension but doesn't provide basic fuctionality.

@yossix
Copy link

yossix commented Jun 25, 2024

++

1 similar comment
@OWarway
Copy link

OWarway commented Jun 27, 2024

++

@g-costantini-it
Copy link

g-costantini-it commented Jul 4, 2024

++
I cannot send empty string value for some Order Note Attributes because of ERPs.
I really need a solution to this issue, The real world is different, and contains accidental complexity and tech debt.

Thank you in advance for the support!

@imperfect-circuits
Copy link

++

This has been brought up in Shopify's Checkout Extensibility AMA (https://community.shopify.com/c/community-amas-ask-me-anything/partner-ama-checkout-extensibility/m-p/2675227/highlight/true#M717).

Hopefully this will get it looked into.

@LauraHirtop
Copy link

plus one

@baloran
Copy link

baloran commented Sep 24, 2024

++

Do you have any information about it? We're facing some issues with our partners because of this.

@yosef-grant
Copy link

Bumping this issue

@AndrieseiMiruna
Copy link

Plus one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests