Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS UI Extensions: Allow same variant with different properties added as separate line items #1021

Open
pablogiralt opened this issue Jun 16, 2023 · 6 comments
Labels
enhancement New feature or request POS UI Extensions

Comments

@pablogiralt
Copy link

Please list the related package(s)

retail-ui-extensions v1.1.2

If this related to specific APIs or components, please list them here

addLineItem from the Cart API

Is your feature request related to a problem? Please describe.

It is currently impossible to have the same variant, with different lineItem properties, in different lines of the cart.

Currently, when adding a lineItem to the cart in POS, the api allows us to specify the variant and quantity we want to add. It however does not allow us to specify line item properties with that payload. Instead, we need to add line item properties based on the line item uuid after the fact. This creates an issue where you cannot add the same variant with different line item properties.

This is inconsistent with the Online Store and prevents the implementation of solutions to meet different requirements for clients. For example:

  • You sell custom rings with engraving, and your customer wants to buy three rings for his daughters Jill, Kelly and Laura.
  • You sell food and the same variant can have different discounts based on the date of expiry.
  • You sell bundles and you want to add the same variant in different bundles. (We use a bundleId lineItem property to tie bundles together in Online Stores, for example here)
    ... and I am use that there is a lot more use cases.

This is an issue in App Bridge with has been reported years ago Shopify/shopify-app-bridge#28

Describe the changes you are looking for

  • Add a parameter to the addLineItem method to add line-item properties when adding the lineItem to the POS cart.
  • Separate lineItems with the same variantId but different lineItem properties in the POS cart, pairing the behaviour with the online store

Describe alternatives you’ve considered

There are really no effective alternatives to this issue. Workarounds can be found for some possible use cases but there are others where there is no possible alternative.

@pablogiralt pablogiralt added the enhancement New feature or request label Jun 16, 2023
@ckeyes88
Copy link

@pablogiralt thanks for adding it here. This has been a big issue without a workaround for years! Would love to see this actually get addressed.

@dnagoda
Copy link
Contributor

dnagoda commented Jun 20, 2023

Thanks for the request. I've added this to our enhancements request backlog for review.

@fred-quickfiredigital
Copy link

@pablogiralt what happens if you add variant 1 with a quantity of 1, then add the line item property to it. than add a second variant 1 with quantity 1. does the it get added to the same line item or is a new one created?

@pablogiralt
Copy link
Author

@pablogiralt what happens if you add variant 1 with a quantity of 1, then add the line item property to it. than add a second variant 1 with quantity 1. does the it get added to the same line item or is a new one created?

@fred-quickfiredigital currently line-items for same variant in pos cart are never "unfolded". So yes, items with same variant_id are always added to same line, even if the the line had a line property before adding the new item.

@pkhanal pkhanal assigned pkhanal and unassigned pkhanal Nov 1, 2023
@tommypepsi
Copy link

tommypepsi commented May 16, 2024

We just encountered that issue while building a POS app... That's a really big issue. That makes the line item properties pretty much useless if you cannot add the same item twice with different properties.

@pohnean
Copy link

pohnean commented Dec 31, 2024

+1

Please fix this! I'm trying to build a gift with purchase app and it's impossible to do it without being able to pass properties in addLineItem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request POS UI Extensions
Projects
None yet
Development

No branches or pull requests

8 participants