Add go-to-definition for global variables #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Iteration of #2644
Handle global variables in definition request.
Implementation
Follow existing pattern, first listen
on_global_variable_read_node_enter, then search for entries in index with variable name, finally push each entry location in response.Automated Tests
I added a basic test, not sure if indexing RBS for the test case is really needed here, happy to have feedback on it.
Manual Tests
Write $DEBUG within a file, then cmd + click on it, you must be redirected to RBS declaration.
Kapture.2024-10-05.at.00.34.44.mp4