Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RuboCop Layout/ClassStructure #2666

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Enable RuboCop Layout/ClassStructure #2666

merged 1 commit into from
Oct 7, 2024
+44 −18

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Oct 4, 2024 •
edited
Loading

@andyw8 andyw8 mentioned this pull request Oct 4, 2024
Merged
@andyw8
Copy link
Contributor Author

andyw8 commented Oct 4, 2024

rubocop/rubocop#13295

@andyw8 andyw8 force-pushed the andyw8/enable-rubocop-class-structure branch from 83d50e4 to 5d8d0f6 Compare October 4, 2024 20:16
@andyw8 andyw8 changed the title Enable RuboCop class structure Enable RuboCop Layout/ClassStructure Oct 4, 2024
@andyw8 andyw8 marked this pull request as ready for review October 4, 2024 20:18
@andyw8 andyw8 requested a review from a team as a code owner October 4, 2024 20:18
@andyw8 andyw8 requested review from alexcrocha and vinistock October 4, 2024 20:18
@andyw8 andyw8 added the chore Chore task label Oct 4, 2024
@andyw8 andyw8 force-pushed the andyw8/enable-rubocop-class-structure branch from 5d8d0f6 to 80f82c8 Compare October 4, 2024 20:19
andyw8
andyw8 commented Oct 4, 2024
View reviewed changes
test/global_state_test.rb Outdated Show resolved Hide resolved
Earlopain
Earlopain reviewed Oct 4, 2024
View reviewed changes
.rubocop.yml Outdated Show resolved Hide resolved
vinistock
vinistock approved these changes Oct 7, 2024
View reviewed changes
.rubocop.yml Outdated Show resolved Hide resolved
test/global_state_test.rb Outdated Show resolved Hide resolved
@andyw8 andyw8 force-pushed the andyw8/enable-rubocop-class-structure branch 2 times, most recently from 43d49f9 to 95fccba Compare October 7, 2024 14:29
@andyw8 andyw8 force-pushed the andyw8/enable-rubocop-class-structure branch from 95fccba to 9a57203 Compare October 7, 2024 14:32
@andyw8 andyw8 enabled auto-merge (squash) October 7, 2024 14:33
@andyw8 andyw8 merged commit 844c0c3 into main Oct 7, 2024
34 checks passed
@andyw8 andyw8 deleted the andyw8/enable-rubocop-class-structure branch October 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Earlopain Earlopain Earlopain left review comments

@vinistock vinistock vinistock approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha alexcrocha is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyw8 @Earlopain @vinistock