Prevent non keywords from accidentally matching on type formatting #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
reviewed
Jul 25, 2024
vinistock
force-pushed
the
vs-prevent-keyword-on-type-formatting-mismatch
branch
from
d420cc7 to
898e0df
Compare
andyw8
approved these changes
Jul 25, 2024
|
@vinistock does this also solve #2302 ? |
|
No, that issue is related to the grammar rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2301
Our regexes for matching when to add the
endtoken were a little too permissive. We were accidentally matching something likeclass: "bg-white"as aclasskeyword.Implementation
The reality is that there are only two possibilities for all of the keywords we provide on type formatting for: either there needs to be a space right after the keyword or they need to be at the end of the line.
Automated Tests
Added a test to ensure we don't regress.