Make module tracking lazy #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Morriar
reviewed
Apr 26, 2024
| attr_accessor :included_modules | ||
| sig { returns(String) } | ||
| def short_name | ||
| T.must(@name.split("::").last) |
There was a problem hiding this comment.
This method is actually dead #1980. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a small optimization to how we're tracking included and prepended modules. There's no need to eagerly create the arrays to store them, since there might be many modules that don't include or prepend anything.
Implementation
Made the modules initialization lazy, so that the arrays are only created if we actually found an include or prepend.